Fix floating point precision failure caused by FMA on ppc64le #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comments as for #213. |
|
Also, please can you rebase this on the latest |
prashantkhoje
force-pushed
the
ppc64le-fma-failure-cdb
branch
2 times, most recently
from
20d729b to
330b287
Compare
prashantkhoje
force-pushed
the
ppc64le-fma-failure-cdb
branch
from
330b287 to
7febab4
Compare
This was exposed while testing CockroachDB. The geomfn/TestShortestLineString fails due to floating point precision differences caused by FMA on ppc64le. See https://go.dev/ref/spec#Floating_point_operators for more details.
prashantkhoje
force-pushed
the
ppc64le-fma-failure-cdb
branch
from
7febab4 to
38ee833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was exposed while testing CockroachDB.
The geomfn/TestShortestLineString fails due to floating point precision differences caused by FMA on ppc64le.
See https://go.dev/ref/spec#Floating_point_operators for more details.