Skip to content

Commit

Permalink
Fix GLFW error on macos
Browse files Browse the repository at this point in the history
This is the error:
GLFW error 65548: Cocoa: Regular windows do not have icons on macOS.

Please make sure you have up-to-date drivers (see aka.ms/mcdriver for instructions).

Fix from minerllabs#659 (comment)
See more info LWJGL/lwjgl3#695
  • Loading branch information
twoturtles committed Oct 13, 2024
1 parent 466411d commit fdaa381
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion scripts/mcp_patch.diff
Original file line number Diff line number Diff line change
Expand Up @@ -3607,10 +3607,13 @@ diff -U0 -rN MCP-Reborn-vanilla/src/main/java/net/minecraft/client/KeyboardListe
+
diff -U0 -rN MCP-Reborn-vanilla/src/main/java/net/minecraft/client/MainWindow.java MCP-Reborn/src/main/java/net/minecraft/client/MainWindow.java
--- MCP-Reborn-vanilla/src/main/java/net/minecraft/client/MainWindow.java 2024-10-13 15:15:59
+++ MCP-Reborn/src/main/java/net/minecraft/client/MainWindow.java 2024-10-13 15:13:00
+++ MCP-Reborn/src/main/java/net/minecraft/client/MainWindow.java 2024-10-13 15:44:17
@@ -88,0 +89,2 @@
+ GLFW.glfwWindowHint(GLFW.GLFW_RESIZABLE, GLFW.GLFW_FALSE);
+ GLFW.glfwWindowHint(GLFW.GLFW_VISIBLE, GLFW.GLFW_FALSE);
@@ -172 +174 @@
- GLFW.glfwSetWindowIcon(this.handle, buffer);
+ //GLFW.glfwSetWindowIcon(this.handle, buffer);
@@ -280,0 +283,19 @@
+ public void resize(int newWidth, int newHeight) {
+ if (width == newWidth && height == newHeight) {
Expand Down

0 comments on commit fdaa381

Please sign in to comment.