Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code consistency changes for master by CodeOversight #26

Closed
wants to merge 4 commits into from

Conversation

twoelevenjay
Copy link
Owner

This pull request contains code consistency changes made by CodeOversight.

This PR is for branch master

@jrfnl
Copy link
Collaborator

jrfnl commented Jul 15, 2016

Nearly all of this looks good - just some @return statements which look weird (have a . behind them which would be better removed than aligned)

Edit: oh and the extra space in the parameter comments which is wrong (and in the travis fail report).

@jrfnl
Copy link
Collaborator

jrfnl commented Jul 15, 2016

Just had a quick look at why travis is failing:

You can ignore the Blank line found after control structure (WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterEnd) errors for now. These are probably caused by a known bug in WPCS - see WordPress/WordPress-Coding-Standards#597

@twoelevenjay
Copy link
Owner Author

Thank you @jrfnl this PR was generated by CodeOversight. Doing some early access alpha / beta testing for @JeroenSormani. I wasn't gonna merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants