Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MockAwareDoctestFinder #27

Open
twmr opened this issue May 6, 2021 · 1 comment
Open

Remove MockAwareDoctestFinder #27

twmr opened this issue May 6, 2021 · 1 comment

Comments

@twmr
Copy link
Owner

twmr commented May 6, 2021

I think the MockAwareDoctestFinder code from https://github.com/thisch/pytest-sphinx/blob/0e4ec60b720ba8d6afd1cf24e2a20e3ba8d6dd4f/pytest_sphinx.py#L494
can be removed (once we drop support for < python 3.10), because the issue we had with it has been fixed (I guess)

https://bugs.python.org/issue35753

Once we have python3.10 in the CI, we can try to check if this code is no longer needed.
twmr added a commit that referenced this issue May 14, 2022
@twmr
Don't use MockAwareDocTestFinder in py3.10
4e74541 
Due to a fix in the python stdlib the MockAwareDocTestFinder is no
longer needed in py3.10

Related: #27
@tony
Copy link
Contributor

tony commented Sep 9, 2022 •
edited
Loading

If we removed MockAwareDoctestFinder we will be able to remove warn_unused_ignores = true (ef5cdfa)

The python version condition + type:ignore causes issues when running against CI with python versions matrix'd (see: python/mypy#8823)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tony @twmr