Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kgo groups: block join&sync while a commit is inflight #410

Merged
merged 1 commit into from
Apr 1, 2023
Merged

kgo groups: block join&sync while a commit is inflight #410

merged 1 commit into from
Apr 1, 2023

Conversation

twmb
Copy link
Owner

@twmb twmb commented Mar 23, 2023

See comments. This is also a different and arguably better approach to the old issue #137.

Closes #409.
Closes #137.

This was referenced Mar 23, 2023
Merged
Closed
@twmb
kgo groups: block join&sync while a commit is inflight
ee70930 
See comments. This is also a different and arguably better approach to
the old issue #137.

The implementation has to be a bit insane because we want to obey the
context while _also_ trying to grab a lock, which cannot be canceled.

Closes #409.
Closes #137.
@twmb twmb merged commit 858f9a0 into master Apr 1, 2023
@twmb twmb deleted the 409 branch April 1, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question] REBALANCE_IN_PROGRESS error while committing offsets
1 participant
@twmb