kgo: add option to consume preferring laggy partitions #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were encoding fetch requests as v12, meaning we avoided topic UUID's. We now ensure we are always encoding the latest version and add a test for it.
This adds three new APIs:
func ConsumePreferringLagFn(fn PreferLagFn) ConsumerOpt
type PreferLagFn func(lag map[string]map[int32]int64, torderPrior []string, porderPrior map[string][]int32) ([]string, map[string][]int32)
func PreferLagAt(preferLagAt int64) PreferLagFn
These functions allow an end user to adjust the order of partitions that
are being fetched. Ideally, an end user will only need:
kgo.ConsumePreferringLagFn(kgo.PreferLagAt(50))
But, PreferLagFn exists to allow for more advanced use cases.
Closes #222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new APIs:
These functions allow an end user to adjust the order of partitions that
are being fetched. Ideally, an end user will only need:
But, PreferLagFn exists to allow for more advanced use cases.
Closes #222