Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fetches.NumRecords(), Fetches.Empty() #191

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

un000
Copy link

@un000 un000 commented Aug 10, 2022

#188 (comment)

Following pattern allocates a new slice under the hood.

if len(fetches.Records()) == 0 {
		return nil
}

Add helper methods which calculates total fetch size without allocation.

@twmb

@twmb
Copy link
Owner

twmb commented Aug 15, 2022

Update on where I'm at, I'm going to try to solve #190 before preparing for the next release and merging this, but that issue has proven to be quite complicated.

Copy link
Owner

@twmb twmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm going to merge this. I might modify a doc line a bit locally, but this is good.

@twmb twmb merged commit d42e6c4 into twmb:master Aug 22, 2022
@twmb
Copy link
Owner

twmb commented Aug 22, 2022

This has been released in v1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants