Support delegation of offset management before consumer group topic consumption begins #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, I think I may have a comment around some doc string aspect, but I plan to look more either tomorrow or Tuesday. Thanks for the PR, interesting idea! I also need to look into if relative offsets are supported in this code path (I think they may be, but just need to dive in). |
|
@twmb anything noteworthy I should be aware of? |
twmb
reviewed
Jan 6, 2022
twmb
reviewed
Jan 6, 2022
twmb
reviewed
Jan 6, 2022
|
Looks good, thanks! I'll issue a tag shortly, I have some changes locally I'm working on as well that I aim to finish tonight. |
|
Tagged in v1.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the features preventing full adoption of
franz-goin my application was the ability for consumer groups to swizzle offsets upon assignment of topics & partitions before consumption on those topics begins. Inconfluent-kafka-gothis is illustrated via this example.This PR offers a means via callback function (set with a GroupOpt) to intercept those assignments and change them before cursors are created.