Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer: close fetch sessions on consumer close #349

Closed
twmb opened this issue Feb 10, 2023 · 0 comments · Fixed by #372
Closed

consumer: close fetch sessions on consumer close #349

twmb opened this issue Feb 10, 2023 · 0 comments · Fixed by #372
Labels
enhancement New feature or request

Comments

@twmb
Copy link
Owner

twmb commented Feb 10, 2023

apache/kafka@e903f2c
@twmb twmb added the enhancement New feature or request label Feb 22, 2023
twmb added a commit that referenced this issue Feb 25, 2023
@twmb
consuming: close fetch sessions when closing the client
aa4ee61 
We allow 1s to send a final empty fetch request indicating that the
fetch session should be closed.

This also fixes the previous direct-consumer path that allowed consuming
to continue while the client was shutting down, which could potentially
result in a spurious context.Canceled rather than ErrClientClosed error.

Closes #349.
@twmb twmb mentioned this issue Feb 25, 2023
Merged
twmb added a commit that referenced this issue Feb 25, 2023
@twmb
consuming: close fetch sessions when closing the client
e45cd72 
We allow 1s to send a final empty fetch request indicating that the
fetch session should be closed.

This also fixes the previous direct-consumer path that allowed consuming
to continue while the client was shutting down, which could potentially
result in a spurious context.Canceled rather than ErrClientClosed error.

Closes #349.
@twmb twmb closed this as completed in #372 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consuming: close fetch sessions when closing the client twmb/franz-go
1 participant
@twmb