pkg/kmsg: annotate max version, min-max version

Previously, only non-zero min versions were commented and they had no upper bound. We now comment all possible ranges.
twmb · Nov 6, 2022 · ba55f7d · ba55f7d
1 parent a07b8c8
commit ba55f7d
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 32 deletions.
diff --git a/generate/gen.go b/generate/gen.go
@@ -1,6 +1,7 @@
 package main
 
 import (
+	"fmt"
 	"strconv"
 	"strings"
 )
@@ -608,8 +609,13 @@ func (s Struct) WriteDefn(l *LineWriter) {
 			l.Write("%s", f.Comment)
 		}
 		versionTag := ""
-		if f.MinVersion > 0 {
-			versionTag = " // v" + strconv.Itoa(f.MinVersion) + "+"
+		switch {
+		case f.MinVersion > 0 && f.MaxVersion > 0:
+			versionTag = fmt.Sprintf(" // v%d-v%d", f.MinVersion, f.MaxVersion)
+		case f.MinVersion > 0:
+			versionTag = fmt.Sprintf(" // v%d+", f.MinVersion)
+		case f.MaxVersion > 0:
+			versionTag = fmt.Sprintf(" // v0-v%d", f.MaxVersion)
 		}
 		if f.Tag >= 0 {
 			if versionTag == "" {

diff --git a/pkg/kmsg/generated.go b/pkg/kmsg/generated.go