Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint displays incorrect when query-input has own styles #325

Closed
wants to merge 1 commit into from

Conversation

AntonPalyok
Copy link
Contributor

Problem appears when query-input has inline style or css-class or computed css-style like

div input { 
    font-size: 200%; 
    padding: 5px;
}

This issue could be fixed if I add cssClasses .tt-query, .tt-hint everywhere in my site.css file.
But what if I don't have access to that file or I want to display few different autocompletes on the page?
Would be fine if plugin can take styles for hint from requested element.

Now its style will be equals to query input.
@jharding
Copy link
Contributor

At first glance, I'm a fan of this pull request. I'll need to do some testing to make sure this works as expected across all supported browsers, but assuming that goes well, this should get merged.

@jharding
Copy link
Contributor

Merged into integration-0.10.0. Thanks!

@jharding jharding closed this Jul 11, 2013
@AntonPalyok
Copy link
Contributor Author

Cool! When do you planning to release version 0.10.0?

@jharding
Copy link
Contributor

End of July at the latest. Since it was such a major overhaul, I need to update all the documentation/examples and I'd also like to release a beta version to get some feedback. There's also a handful of features I still need to implement. If you want to be notified when the beta is ready of when v0.10.0 has been released, I'd suggest either following @typeahead on Twitter or watching #335.

@caseydm
Copy link

caseydm commented Aug 18, 2013

Anton and jharding,

I'm dealing with this issue right now and am wondering how I can resolve it before 0.10 comes out. I've almost corrected the problem but my text is not lining up. See an example here: http://bahcalculator.org/nano/

Do you have a better suggestion to resolve this, over using ! important in multiple CSS classes to overcome the inline CSS?

Thanks,
Casey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants