0.9.7 #161
Merged
0.9.7 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use docker-compose and mount volume between host and container properly
and now we require spec.required_ruby_version = '>= 2.5.0' so no need to have this condition anymore
Although the description says "Sends the specified data as it is..." it's actually parsing input data using CGI.parse() method. This isn't ideal, especially when sending JSON data, for instance. This commit changes this behavior and makes that option a real thing, so users can also send JSON data using -r option by setting the content-type request header using -A option. For backword-compatibility, we still allow -d option to send JSON data as long as "content-type: application/json" request header is set. Also, since -r takes input data as-is, it doesn't really make sense to allow combine use with -d option or adding -r option more than once, so we treat them as an error going forward.
This commit can be reverted once new Ruby 3 patch/minor version has released.
|
Hi @andypiper, let me know if you have any questions. Not sure why Travis CI is stuck with "received" status but once it's started this should pass tests on all versions. Thanks |
|
Also, since we're not really using Coveralls, can just remove it from - SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
+ SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter] |
This was referenced Jan 22, 2021
osowskit
reviewed
Feb 2, 2022
|
No activities for code review/approval for more than a year. Closing this PR. |
|
@smaeda-ks review is happening now - thank you so much for this. Re-opening. |
|
ok, then I'll have to revisit and make sure this works on more recent Ruby versions. With that said, this PR is not ready for an immediate review anyhow. |
|
Hi @andypiper, this PR should be ready for merging. Added a few comments due to #173 but should be all set. Could you please merge this so we can release 0.9.7? Thanks |
This was
linked to
issues
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/
--no-ssloption as all endpoints are now forced to use TLS anyway-voption to include Ruby runtime version-doption twurl posting tweet errors with '&' escape #157--raw-dataoption behaviorBreaking Changes
impact:
lowchanging
--raw-dataoption behaviorAlthough the description says
Sends the specified data as it is...it's actually parsing input data usingCGI.parse()method. This isn't ideal, especially when it comes to JSON data, for instance. We shouldn't touch the specified raw data at all.This commit changes this behavior and makes this option a real thing, so users can also send JSON data using
-roption by properly setting thecontent-typerequest header using-Aoption. For backword-compatibility, we still allow-doption to send JSON data as long ascontent-type: application/jsonrequest header is set along with it.Also, since
-rtakes input data as-is, it doesn't make sense to allow combine use with-doption or adding-roption more than once, so we treat them as an error going forward.