-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update finagle and other twitter deps to 2019 compatible versions. #361
Conversation
Don Smith III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
thanks for the PR, if we can get this green, I'll merge it. |
Codecov Report
@@ Coverage Diff @@
## develop #361 +/- ##
===========================================
+ Coverage 61.21% 61.49% +0.28%
===========================================
Files 119 119
Lines 1815 1792 -23
Branches 116 116
===========================================
- Hits 1111 1102 -9
+ Misses 704 690 -14
Continue to review full report at Codecov.
|
thanks @johnynek! looks like i've finally got it fixed up. edit: the mima previous versions will have to be uncommented after an artifact is published. |
Any chance we can get this merged? |
@johnynek mind having a look at this? |
The (still unreleased) develop version of storehaus is not binary compatible with the current versions of Finagle. This PR updates them to recent versions by using the twitter Bufs provided in the new finagle-x clients, and removes ChannelBuffers which were obsoleted with the release of netty 4.