Upgrade finagle to 6.43.0 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttim
approved these changes
May 11, 2017
| case (k, Some(buf)) => | ||
| val req = Request(Method.Put, k) | ||
| req.content = buf | ||
| req.contentLength = buf.length |
There was a problem hiding this comment.
Is buf.length the same as .readableBytes?
There was a problem hiding this comment.
yeah, seem to be afaict.
Codecov Report
@@ Coverage Diff @@
## develop #347 +/- ##
===========================================
- Coverage 61.16% 61.16% -0.01%
===========================================
Files 119 119
Lines 1813 1818 +5
Branches 117 117
===========================================
+ Hits 1109 1112 +3
- Misses 704 706 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades finagle and twitter util. In the process gets rid of finagle-http-compat and moves to the latest finagle http api.