Cleanup storehaus-redis #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be made better once #310 is done. |
johnynek
requested changes
Sep 23, 2016
| @@ -45,7 +44,7 @@ class RedisHashStore(val client: Client, ttl: Option[Duration]) | |||
| extends Store[ChannelBuffer, Map[ChannelBuffer, ChannelBuffer]] { | |||
|
|
|||
| override def get(k: ChannelBuffer): Future[Option[Map[ChannelBuffer, ChannelBuffer]]] = | |||
| client.hGetAll(k).map({ case e if (e.isEmpty) => None case xs => Some(Map(xs:_*)) }) | |||
| client.hGetAll(k).map { case e if e.isEmpty => None case xs => Some(Map(xs: _*)) } | |||
There was a problem hiding this comment.
can we make two lines:
.map {
case e if e.isEmpty => None
case xs => Some(Map(xs: _*))
}
|
ping @johnynek 😄 |
johnynek
reviewed
Oct 6, 2016
| @@ -34,7 +33,8 @@ object RedisSortedSetStore { | |||
| */ | |||
| class RedisSortedSetStore(client: Client) | |||
| extends MergeableStore[ChannelBuffer, Seq[(ChannelBuffer, Double)]] { | |||
| def semigroup = implicitly[Semigroup[Seq[(ChannelBuffer, Double)]]] | |||
| def semigroup: Semigroup[Seq[(ChannelBuffer, Double)]] = | |||
| implicitly[Semigroup[Seq[(ChannelBuffer, Double)]]] | |||
There was a problem hiding this comment.
Is this really the semigroup that redis is doing? I tend to doubt it. Seems like the value is more like Map[ChannelBuffer, Double]. Can we add a test that the semigroup we declare here is consistent with how redis works?
We could do that by comparing .multiMerge here on a big set of items to what we would get from MergeableStore.fromStore and using the semigroup here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.