Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey hbase unit tests #300

Merged
merged 5 commits into from
Jun 13, 2016
Merged

Fix flakey hbase unit tests #300

merged 5 commits into from
Jun 13, 2016

Conversation

BenFradet
Copy link
Contributor

fixes #294

@BenFradet
Copy link
Contributor Author

I'll rebase once #299 is merged

@BenFradet
Copy link
Contributor Author

I think I'll just remove the multiput property since multiput is not implemented in the hbase store.

@BenFradet
Copy link
Contributor Author

I'll run the tests 10 times to see if the hbase tests are fixed

@BenFradet
Copy link
Contributor Author

BenFradet commented Jun 13, 2016

@johnynek ran the suites 10 times and no hbase tests failed, tell me when you want me to rebase.

@johnynek
Copy link
Collaborator

This looks great, thanks so much. If you rebase, I'll keep running the tests until elastic search passes. :(

@BenFradet
Copy link
Contributor Author

Could you merge #299 first since I checked out from this branch to avoid having to go through the humongous quantity of logs? In the meantime I'll remove the unnecessary commits.

@BenFradet BenFradet changed the title [wip] Fix flakey hbase unit tests Fix flakey hbase unit tests Jun 13, 2016
@BenFradet
Copy link
Contributor Author

@johnynek done 👍

@johnynek johnynek merged commit bcbd9dd into twitter:develop Jun 13, 2016
@johnynek
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HBaseStringStoreProperties test is flaky
2 participants