Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bijection/algebird versions #253

Merged
merged 2 commits into from
Dec 18, 2014
Merged

Bump bijection/algebird versions #253

merged 2 commits into from
Dec 18, 2014

Conversation

franklinhu
Copy link
Contributor

  • Bump algebird to 0.8.2
  • Bump bijection to 0.7.0
  • Fix Successible API change

@franklinhu
Copy link
Contributor Author

Hm are the tests known to be flaky sometimes? The elasticsearch tests seem to pass locally.

@MansurAshraf
Copy link
Contributor

I have restarted the build. Lets see if it passes this time

@franklinhu
Copy link
Contributor Author

So it seems like this is some issue with the Elasticsearch tests running in parallel. Changing it to run sequentially seems to fix the issue, although doesn't inspire a lot of confidence in what it's testing.

johnynek added a commit that referenced this pull request Dec 18, 2014
@johnynek
Merge pull request #253 from franklinhu/franklin-algebird-0.8.2
02295fa 
Bump bijection/algebird versions
@johnynek johnynek merged commit 02295fa into twitter:develop Dec 18, 2014
@franklinhu franklinhu deleted the franklin-algebird-0.8.2 branch December 18, 2014 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franklinhu @MansurAshraf @johnynek @franklin-stripe