Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump finagle and util to 6.22.0 #247

Merged
merged 2 commits into from
Dec 11, 2014
Merged

Conversation

dschobel
Copy link
Contributor

@dschobel dschobel commented Dec 9, 2014

this bumps finagle and util to 6.22.0 and fixes the finagle-mysql usage which has changed since 6.12.2.

there aren't any published 2.9 artifacts for finagle and util 6.22.0 so this breaks that build.

https://travis-ci.org/dschobel/storehaus/builds/43419185

@rubanm
Copy link
Contributor

rubanm commented Dec 9, 2014

Mysql store changes LGTM, thanks.

So looks like we'll need the kill 2.9.3 change #248 to be merged before merging this?

@ianoc ianoc mentioned this pull request Dec 10, 2014
@ianoc
Copy link
Collaborator

ianoc commented Dec 10, 2014

@dschobel can you merge in develop? I've killed 2.9.3 in a small patch there. So hopefully we can get yours in and cut you a snapshot.

rubanm added a commit that referenced this pull request Dec 11, 2014
@rubanm rubanm merged commit 841b2e7 into twitter:develop Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants