implementation of store that uses http protocol #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def apply(dest: String): HttpStringStore = new HttpStringStore(Http.newService(dest)) | ||
| } | ||
|
|
||
| class HttpStringStore(val client: Service[HttpRequest, HttpResponse]) extends Store[String, String] { |
There was a problem hiding this comment.
Looks like this one can be implemented as a ConvertedStore?
if you have an Injection[String, ChannelBuffer]
class HttpStringStore(store: HttpStore)
extends ConvertedStore[String, String, ChannelBuffer, String](store)(identity)(inj)
|
@koertkuipers Thanks for the PR! One comment on using ConvertedStore. LGTM otherwise. |
|
failure seems unrelated to pullreq. want to to try get travis going again? |
|
Restarted .. |
|
@koertkuipers Looks like the http store tests never ran. Want to add an entry here? |
|
ah my bad. i will add it |
ianoc
added a commit
that referenced
this pull request
Oct 21, 2014
implementation of store that uses http protocol
|
Tests look good, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.