Added endpoint support to storehaus-dynamodb #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import com.amazonaws.services.dynamodbv2.model._ | ||
|
|
||
| import AwsBijections._ | ||
|
|
||
| object DynamoLongStore { | ||
| def apply(awsAccessKey: String, awsSecretKey: String, tableName: String, primaryKeyColumn: String, valueColumn: String) = | ||
| new DynamoLongStore(DynamoStore(awsAccessKey, awsSecretKey, tableName, primaryKeyColumn, valueColumn)) | ||
| def apply(awsAccessKey: String, awsSecretKey: String, endpoint: Regions, tableName: String, |
There was a problem hiding this comment.
can you add a default version equivalent to the old one? No need to break people if we don't need to, right?
There was a problem hiding this comment.
Yup sure, was thinking of doing that initially.
|
@BenFradet Can you merge in develop? We fixed an issue causing intermittent build failures - #237 Thanks. |
|
Yup sure, thanks for the heads up. |
|
Travis ci passed. Merging. Thanks. |
rubanm
added a commit
that referenced
this pull request
Aug 5, 2014
Added endpoint support to storehaus-dynamodb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storehaus-dynamodb is limited to the default aws endpoint which is us-east1 and we're working in Europe.