Exceptions on the cache-store should be ignored for Read/WriteThroughStore #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Store Use Future#transform variants instead of respond's on XxxThroughStore
| @@ -0,0 +1,13 @@ | |||
| package com.twitter.storehaus | |||
There was a problem hiding this comment.
This file needs the copyright/license header
|
@solar Thanks for the fix. Just curious if you've tried this combinator in the wild? |
configurable possibility of exceptions
|
I was trying to use it (not in production yet). |
rubanm
added a commit
that referenced
this pull request
Apr 4, 2014
Exceptions on the cache-store should be ignored for Read/WriteThroughStore
|
@solar Great, I'm interested in learning more about how you're using this, with which backing stores etc. Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that those behaviors are intended or not.
But using
Future#respondvariants like.onFailure { case x: Exception => storeValue }are meaningless.(
onFailurewon't transform into newFuture, it will simply register a callback)Use
Future#transformvariants instead ofFuture#responds on XxxThroughStore