Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MergeableStore.fromStoreNoMulti that does single get then put #201

Merged
merged 3 commits into from
Dec 18, 2013

Conversation

singhala
Copy link
Contributor

No description provided.

@@ -71,6 +71,13 @@ object MergeableStore {
fc: FutureCollector[(K, Option[V])]): MergeableStore[K,V] =
new MergeableStoreViaGetPut[K, V](store, fc)

/** Create a mergeable by implementing merge with single get followed by put for each key.
* Only safe if each key is owned by a single thread. Useful in certain cases where multiGets and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add that this forces multGet/multiPut to be the default implementation?

johnynek added a commit that referenced this pull request Dec 18, 2013
add MergeableStore.fromStoreNoMulti that does single get then put
@johnynek johnynek merged commit 85a70aa into twitter:develop Dec 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants