Redis sorted sets part deux #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
@softprops thinking of publishing a version soon. Want to merge with develop and get this green? Hoping to publish soon to enable a feature in summingbird that needs merge to emit the previous value. |
Conflicts: storehaus-redis/src/main/scala/com/twitter/storehaus/redis/RedisSortedSetStore.scala
|
merged with develop. was only a minor merge conflict. cool stuff |
|
whoa! Travis says. "I'm sorry but your test run exceeded 50.0 minutes." I'm not sure whats holding up the line bug not a whole lot changed in this branch. |
|
It looks like one of the other backends had some issue that caused it to deadlock/hang running. Restarting the tests will probably do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a follow up to the redis sorted sets branch ( now with tests! )