Added AsyncHBase based Store #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sritchie So I ran into an issue with Storm/SummingBird while using the HBase store. Basically Storm is shipping with Zookeeper 3.3.x due to a bug in Curator (see nathanmarz/storm#225) and newer version of HBase require Zookeeper 3.4.x. Since the pull request above is opened for more than a year, I have not much hope when it will be merged anytime soon. Which means that SummingBird-Storm is also stuck on Zookeeper 3.3.x and any store impl that require latest ZooKeeper will have a hard time. After searching Storm mailing I found that people are using AsyncHBase (https://github.com/OpenTSDB/asynchbase/) to get around this issue. Basically AsyncHBase allow you to use an older version of Zookeeper client to talk to newer version of HBase.
I have added AsyncHbase based store impl in
com.twitter.storehaus.asynchbaseand added a readme explaining the rationale for two different HBase Impls. I have left the original HBase stores as is for now although they dont currently work with SummingBird.I have tested the impl internally and it works fine with summing bird. Let me know if you need me to change anything