Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting maxBytes = 0 does not work #41

Closed
gitdump1 opened this issue Jan 22, 2019 · 2 comments
Closed

Setting maxBytes = 0 does not work #41

gitdump1 opened this issue Jan 22, 2019 · 2 comments

Comments

@gitdump1
Copy link

In our project, we don't want a disk cache so we set [TIPGlobalConfiguration sharedInstance].maxBytesForAllDiskCaches = 0. However, that doesn't seem to be working. I DM'd with @NSProgrammer and he confirmed there are some places where 0 == off and others where 0 == unlimited (ex:

ios-twitter-image-pipeline/TwitterImagePipeline/TIPGlobalConfiguration.m

Line 542 in 8b3eff1

if (globalMaxBytes == 0) {
).
@NSProgrammer
Copy link
Collaborator

This is a legit issue and I can repro. Will work on a fix.

In the meantime, the workaround is to set the max bytes to be 1 byte.

NSProgrammer added a commit that referenced this issue Feb 21, 2019
@NSProgrammer
Update to v2.12.1
e7b436b 
- Fix bugs related to capping the sizes of caches
  - Capping a cache to `0` bytes would not completely disable it as documented, fixed
  - Setting the max ratio value to a negative value would not use the default value as documented, fixed
  - Thanks to @jml5qh for filing this issue (#41)

- Analyzer warning fixes too (not actual bugs)
@NSProgrammer NSProgrammer mentioned this issue Feb 21, 2019
Merged
NSProgrammer added a commit that referenced this issue Feb 21, 2019
@NSProgrammer
Update to v2.12.1 (#42)
9d98639 
- Fix bugs related to capping the sizes of caches
  - Capping a cache to `0` bytes would not completely disable it as documented, fixed
  - Setting the max ratio value to a negative value would not use the default value as documented, fixed
  - Thanks to @jml5qh for filing this issue (#41)

- Analyzer warning fixes too (not actual bugs)
@NSProgrammer
Copy link
Collaborator

Resolved with merge #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NSProgrammer