Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thriftmux -> 213 #794

Closed

Conversation

martijnhoekstra
Copy link
Contributor

Problem

No 2.13 cross-building for finagle-thrift, finagle-mux and finagle-thrift-mux

Solution

Cross-build.

@martijnhoekstra martijnhoekstra mentioned this pull request Sep 13, 2019
28 tasks
Copy link
Contributor

@mosesn mosesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit, LGTM otherwise. I'm surprised this was so easy!

@@ -13,6 +13,7 @@ import com.twitter.finagle.param.{
import com.twitter.finagle.server.{Listener, StackServer, StdStackServer}
import com.twitter.finagle.service.{ResponseClassifier, RetryBudget}
import com.twitter.finagle.stats.{ExceptionStatsHandler, StatsReceiver}
import com.twitter.finagle
import com.twitter.finagle.thrift.{ClientId => _, _}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we instead provide an alias for ClientId that's FinagleClientId?

@codecov-io
Copy link

Codecov Report

Merging #794 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #794      +/-   ##
===========================================
- Coverage    71.83%   71.83%   -0.01%     
===========================================
  Files          859      859              
  Lines        25601    25603       +2     
  Branches      1872     1868       -4     
===========================================
+ Hits         18390    18391       +1     
- Misses        7211     7212       +1
Impacted Files Coverage Δ
...ft/src/main/scala/com/twitter/finagle/Thrift.scala 86.99% <100%> (ø) ⬆️
...la/com/twitter/finagle/mux/transport/Message.scala 88.38% <100%> (ø) ⬆️
...n/scala/com/twitter/finagle/mux/ContextCodec.scala 100% <100%> (ø) ⬆️
.../com/twitter/finagle/tracing/BroadcastTracer.scala 62% <0%> (-6%) ⬇️
...main/scala/com/twitter/finagle/util/LossyEma.scala 96.15% <0%> (-3.85%) ⬇️
...m/twitter/finagle/exp/ConcurrencyLimitFilter.scala 88.57% <0%> (-2.86%) ⬇️
...rtitioning/ConsistentHashPartitioningService.scala 88.63% <0%> (-2.28%) ⬇️
...nagle/http2/transport/StreamTransportFactory.scala 82.91% <0%> (-0.84%) ⬇️
...tter/finagle/redis/protocol/commands/Streams.scala 97.5% <0%> (+1.25%) ⬆️
...om/twitter/finagle/dispatch/ServerDispatcher.scala 85.1% <0%> (+2.12%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d5de4...a6a6ea0. Read the comment docs.

Copy link
Contributor

@mosesn mosesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @martijnhoekstra!

@mosesn mosesn added the Ship It label Sep 18, 2019
@mosesn
Copy link
Contributor

mosesn commented Sep 27, 2019

thanks @martijnhoekstra this got merged here: 47ee31f

@mosesn mosesn closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants