upgraded to Avro 1.7.5. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eric codecs to accommodate class hierarchy change in 1.7.5
| import com.twitter.bijection.Inversion.attempt | ||
| import com.twitter.bijection.Attempt | ||
| import org.apache.avro.generic.{GenericDatumReader, GenericDatumWriter, GenericRecord} | ||
| import org.apache.avro.Schema | ||
| import org.apache.avro.io.{DecoderFactory, DatumReader, EncoderFactory, DatumWriter} | ||
| import Injection.utf8 |
There was a problem hiding this comment.
might want to add the comment that you are ensuring you have the String, Array[Byte] via utf8 (which is the default, BTW, but this does make it safer in case someone accidentally changes the default (why!?!?!) in Injection).
There was a problem hiding this comment.
I will add the comment
|
Looks good to me. Just some minor comments. Nice work as always. |
|
@johnynek take a look and see if it make sense now |
|
@johnynek Is there anything else you need me to do for this PR? |
|
sorry I lost track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created separate objects for Specific and Generic codecs to accommodate class hierarchy change in 1.7.5