Merge pull request #151 from twitter/boolean-buff

Add boolean bufferable
twitter · Nov 20, 2013 · 6d17f90 · 6d17f90
2 parents d830a50 + 7749894
commit 6d17f90
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/bijection-core/src/main/scala/com/twitter/bijection/Bufferable.scala b/bijection-core/src/main/scala/com/twitter/bijection/Bufferable.scala
@@ -149,6 +149,12 @@ object Bufferable extends GeneratedTupleBufferable with Serializable {
     }
 
   // Primitives:
+  implicit val booleanBufferable: Bufferable[Boolean] =
+    buildCatchDuplicate[Boolean] { (bb, x) =>
+      val byte = if(x) 1:Byte else 0:Byte
+      reallocatingPut(bb){ _.put(byte) }
+    } { _.get == (1:Byte) }
+
   implicit val byteBufferable: Bufferable[Byte] =
     buildCatchDuplicate[Byte] { (bb, x) => reallocatingPut(bb){ _.put(x) } } { _.get }
   implicit val charBufferable: Bufferable[Char] =

diff --git a/bijection-core/src/test/scala/com/twitter/bijection/BufferableLaws.scala b/bijection-core/src/test/scala/com/twitter/bijection/BufferableLaws.scala
@@ -65,6 +65,8 @@ object BufferableLaws extends Properties("Bufferable") with BaseBufferable {
   }
 
   implicit val laeq = itereq[List[Array[Byte]], Array[Byte]]
+
+  property("Bools roundtrip") = roundTrips[Boolean]
   property("Ints roundtrip") = roundTrips[Int]
   property("Doubles roundtrip") = roundTrips[Double]
   property("Floats roundtrip") = roundTrips[Float]