This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Convert 3rdparty/python to use the python_requirements target. #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter commons was using a wrapper function around its python
dependencies to create python_requirement_library targets.
The python_requirements library is able to understand a pip
requirements.txt file and convert each entry into the
python_requirement_library target needed by Pants.
The python_requirements target uses the project name as a target
name. The original wrapper was maintained for a few dependencies
when their name clashed with Pants BUILD file conventions.
I also removed the easy_install thrift, it looks like it was
put in place to service aurora, who was later unblocked.
Let me know if you think it should be returned:
pantsbuild/pants#2533
The purpose of this change is to enable a simple interface to convert
some python dependencies from being hardcoded to a single rev into
being able to be satisfied by a release range. I will submit
any dependency version changes separately.