macros: don't use >= in version selector.
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahhhh whelp, sorry about that. I wasn’t thinking when I updated the package. |
|
Should I yank 0.8.0 and 0.8.1 along with when I release this as 0.8.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>=0.8.0matches literally any higher version, with possible breaking changes: 0.8.x, 0.9.x, 1.x, 2.x... This will cause the build of usbd-hid-macros to break when 0.9.0 or higher is relased.This already happened. -macros v0.6 had
>=0.1.2, which broke today when you released v0.8.0, breaking embassy: embassy-rs/embassy#3181 .