Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow depending on byteorder 1.5 #63

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

simpkins
Copy link
Contributor

Update the macros dependency to allow byteorder 1.5 to be used, which was released ~6 months ago. This is needed to make usbd-hid usable with other crates that use byteorder 1.5 in their macros.

@twitchyliquid64
Copy link
Owner

If it works, feel free to just pin it to 1.5 or greater. I assumed youve tested this?

I can merge whenever, but I won't be able to cut a new crates release till i get back from denver in ~days.

@simpkins
Copy link
Contributor Author

simpkins commented Apr 3, 2024

Sorry for the slow reply. I had wanted to get this working on some actual hardware to do more testing, and that took longer than planned. I have confirmed it works fine on some real hardware now, and the cargo test tests pass.

I can go ahead and update this to just depend on 1.5 if that is the preferred approach.

@simpkins
Copy link
Contributor Author

simpkins commented Apr 3, 2024

I just updated this to depend simply on 1.5

Note that it looks like the master branch is currently broken. The most recent commit is trying to call an EndpointIn::maybe_write() method that doesn't exist.

@twitchyliquid64
Copy link
Owner

Ooof, sorry about that. Feel free to fix or revert that commit at your discretion on your branch- serves me right for trying to merge an old PR with spotty cellular on a train lol

@twitchyliquid64
Copy link
Owner

I’m moving today/tomorrow but will once things are good I can merge and cut a new release. My main computer with crates.io creds is in a box at the bottom of the pile

This update the macros dependency to byteorder 1.5, which was released
~6 months ago.  This is needed to make usbd-hid usable with
other crates that depend on byteorder 1.5 for their macros (such as
esp-hal).
@twitchyliquid64 twitchyliquid64 merged commit 76bea16 into twitchyliquid64:master Apr 15, 2024
8 checks passed
@simpkins simpkins deleted the byteorder branch April 25, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants