Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12044 no more urllib2 #12045

Merged
merged 10 commits into from
Dec 2, 2023
Merged

#12044 no more urllib2 #12045

merged 10 commits into from
Dec 2, 2023

Conversation

glyph
Copy link
Member

@glyph glyph commented Nov 30, 2023

Scope and purpose

Fixes #12044

@glyph glyph marked this pull request as ready for review November 30, 2023 01:50
@chevah-robot chevah-robot requested a review from a team November 30, 2023 01:50
@glyph
Copy link
Member Author

glyph commented Nov 30, 2023

please review

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the cleanup. It looks good.
Only minor comments.


I see some typing changes in twisted.web.client and twisted.web.test.test_agent.

Can we now remove the typing exceptions for these modules from pyproject.toml ?


I think it is worth removing the deprecated compat alias in this PR, rather than creating another ticket and another PR and doing another review.


In terms of coverage. There is a missing branch coverage, that was also missing in trunk

image

but I think we are fine

Thanks again

docs/core/howto/tutorial/intro.rst Show resolved Hide resolved
docs/web/howto/listings/client/cookies.py Show resolved Hide resolved
src/twisted/web/client.py Outdated Show resolved Hide resolved
src/twisted/web/client.py Show resolved Hide resolved
src/twisted/web/client.py Show resolved Hide resolved
@glyph
Copy link
Member Author

glyph commented Dec 2, 2023

I see some typing changes in twisted.web.client and twisted.web.test.test_agent.

Can we now remove the typing exceptions for these modules from pyproject.toml ?

This will reduce the amount of work required to do that, but we're not quite finished with the necessary annotations, I don't think.

@glyph glyph enabled auto-merge December 2, 2023 23:48
@glyph glyph merged commit 7697871 into trunk Dec 2, 2023
21 checks passed
@glyph glyph deleted the 12044-no-more-urllib2 branch December 2, 2023 23:58
@adiroiban
Copy link
Member

@glyph. thanks for the cleanup. I will try to make another release by the end of December.
For now, the goal is to have a new release every 2 months.

If I don't forget, I will try to create some cleanup PR before the release to remove any API that is deprecated since a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove all references to urllib2 and cookielib
3 participants