-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12044 no more urllib2 #12045
#12044 no more urllib2 #12045
Conversation
please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the cleanup. It looks good.
Only minor comments.
I see some typing changes in twisted.web.client and twisted.web.test.test_agent.
Can we now remove the typing exceptions for these modules from pyproject.toml
?
I think it is worth removing the deprecated compat alias in this PR, rather than creating another ticket and another PR and doing another review.
In terms of coverage. There is a missing branch coverage, that was also missing in trunk
but I think we are fine
Thanks again
This will reduce the amount of work required to do that, but we're not quite finished with the necessary annotations, I don't think. |
Co-authored-by: Adi Roiban <[email protected]>
Co-authored-by: Adi Roiban <[email protected]>
@glyph. thanks for the cleanup. I will try to make another release by the end of December. If I don't forget, I will try to create some cleanup PR before the release to remove any API that is deprecated since a long time |
Scope and purpose
Fixes #12044