Add treq.cookies helper module
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix a CookieAgent failure. Fixes #384.
If we're going to ditch requests.cookies we need to offer *something* less raw than a bare CookieJar.
adiroiban
approved these changes
May 1, 2024
src/treq/cookies.py
Outdated
| ) | ||
|
|
||
|
|
||
| def raid( |
There was a problem hiding this comment.
minor comment
I am not familiar with other cookie API ... maybe this naming makes sense...maybe this is a fun name... I don't know.
Maybe call it search ? ... to be dull and boring
I was expecting to find this functionality in stdlib
There was a problem hiding this comment.
Ah, yeah, it is perhaps too cute: https://en.wiktionary.org/wiki/caught_raiding_the_cookie_jar
|
@adiroiban Thank you for the swift review! I renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of cookie-related stuff, incrementally stepping towards addressing #325:
scoped_cookie()helper for creatingCookieobjects.search()function for searching a cookiejar.CookieAgentMyPy failure.treq.response._Response(including itscookie()method).Fixes #384.