GitHub Actions CI config #308

twm · 2020-12-22T22:32:47Z

Closes #307.

This seems sufficiently ancient as a lower bound.

The PyPy builds are failing due to our good friend Twisted #9985 [1]: main function encountered error Traceback (most recent call last): File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks _inlineCallbacks(None, g, status) File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks result = g.send(result) File ".../treq/.tox/pypy3-twisted_latest/site-packages/treq/test/local_httpbin/child.py", line 175, in _serve_tls port = yield endpoint.listen(site) File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/endpoints.py", line 1092, in listen interface=self._interface) --- <exception caught here> --- File ".../treq/.tox/pypy3-twisted_latest/site-packages/treq/test/local_httpbin/child.py", line 175, in _serve_tls port = yield endpoint.listen(site) File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/defer.py", line 122, in execute result = callable(*args, **kw) File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/posixbase.py", line 521, in listenSSL tlsFactory = tls.TLSMemoryBIOFactory(contextFactory, False, factory) File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/protocols/tls.py", line 773, in __init__ contextFactory = _ContextFactoryToConnectionFactory(contextFactory) File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/protocols/tls.py", line 651, in __init__ oldStyleContextFactory.getContext() File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/_sslverify.py", line 1678, in getContext self._context = self._makeContext() File ".../treq/.tox/pypy3-twisted_latest/site-packages/twisted/internet/_sslverify.py", line 1688, in _makeContext ctx.use_certificate(self.certificate) File ".../treq/.tox/pypy3-twisted_latest/site-packages/OpenSSL/SSL.py", line 865, in use_certificate _raise_current_error() File "/usr/lib/pypy3/lib_pypy/_functools.py", line 80, in __call__ return self._func(*(self._args + fargs), **fkeywords) File ".../treq/.tox/pypy3-twisted_latest/site-packages/OpenSSL/_util.py", line 57, in exception_from_error_queue raise exception_type(errors) OpenSSL.SSL.Error: [('SSL routines', 'SSL_CTX_use_certificate', 'ee key too small')] [1]: https://twistedmatrix.com/trac/ticket/9985

https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-gotcha

As far as I can tell this isn't sensitive? I could create a secret for it in GitHub, but then it woudn't be available to actions associated with PRs from forks.

adiroiban

Looks good. Thanks for the update!

I think that Travis is dying so the migration is a must.

And GitHub Action has a nice UI/UX ,integration with GitHub and good OS coverage

adiroiban · 2020-12-27T02:37:22Z

.github/workflows/ci.yaml

+
+    - run: python -m pip install tox
+
+    - run: tox -q -e flake8


maybe run all 4 in parallel ? maybe it's faster.

Suggested change

- run: tox -q -e flake8

- run: tox -q -p all -e flake8, towncrier, twine, check-manifest

I think that in the future, this can be extended into an automated release to pypi job.

adiroiban · 2020-12-27T02:41:13Z

.github/workflows/ci.yaml

+
+    - run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_${{ matrix.twisted-version }}
+
+    - run: python -m pip install coveralls


why not install coveralls together with tox ?

Good idea, I'll do that.

adiroiban · 2020-12-27T02:41:36Z

.github/workflows/ci.yaml

+    - run: coveralls
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        COVERALLS_REPO_TOKEN: 4nctuKHTnVtbdmty2FgdO3iiWm1nb7xc4


is the coveralls token public ?

As far as I can tell we don't have much choice about it. I looked at putting it in a GitHub Actions secret, but according to the documentation it wouldn't be available on PRs from forks. The Coveralls docs don't seem to treat it like a secret, either — it's at the top of the page, not obscured at all.

IMO Coveralls and Codecov aren't really worth the trouble. I'd rather focus my time on getting treq to 100% coverage than babysit these systems, so I'm not going to worry about it until and unless it becomes a real problem.

adiroiban · 2020-12-27T02:44:06Z

I think that we need a robot / webhook for the whole Twisted organization to automatically update the labels after a review. Manually labels update is not fun.

twm · 2020-12-27T07:02:30Z

Thank you for the review @adiroiban! I've made the changes you suggested.

I think that we need a robot / webhook for the whole Twisted organization to automatically update the labels after a review. Manually labels update is not fun.

Yeah, that would be great to have.

twm force-pushed the github-actions branch from 73b2764 to c02b580 Compare December 22, 2020 22:55

GitHub Actions CI config

c536034

twm force-pushed the github-actions branch from c02b580 to c536034 Compare December 22, 2020 22:57

twm added 2 commits December 22, 2020 15:11

Set minimum Twisted to 18.7.0

237fb6f

This seems sufficiently ancient as a lower bound.

Twisted versions in matrix

c34dcb3

twm force-pushed the github-actions branch from 191e621 to c34dcb3 Compare December 22, 2020 23:14

twm added 5 commits December 22, 2020 15:23

Make PyPy3 and trunk builds experimental

fe5ca65

Add timeouts

b019e20

Remove Travis CI config

46b0878

Nicer job names

2d31fa9

twm marked this pull request as ready for review December 23, 2020 00:55

twm added 3 commits December 22, 2020 16:58

Add newsfragment

08be5fd

Report to coveralls

4e5088c

Coveralls

7e6a75c

https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-gotcha

twm force-pushed the github-actions branch from 82e6339 to 7e6a75c Compare December 23, 2020 01:15

twm added 4 commits December 22, 2020 17:58

Add coveralls repo token

b15fc74

As far as I can tell this isn't sensitive? I could create a secret for it in GitHub, but then it woudn't be available to actions associated with PRs from forks.

Make pypy-3.7 run non-experimental

38bc238

Maybe coveralls needs a checkout?

b7a5a6e

Debugging...

7ba6fef

twm mentioned this pull request Dec 23, 2020

Update treq twisted/klein#401

Merged

Remove failing coveralls --finish

65a9a24

twm requested a review from a team December 26, 2020 23:30

twm added the Ready for Review label Dec 26, 2020

adiroiban approved these changes Dec 27, 2020

View reviewed changes

adiroiban added good to land (with minor changes) and removed Ready for Review labels Dec 27, 2020

twm added 2 commits December 26, 2020 22:55

Combine lints to run in parallel

b5e8518

Combine Tox and Coveralls installs

9d044f5

twm merged commit 3a5da48 into master Dec 27, 2020

twm deleted the github-actions branch December 27, 2020 07:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Actions CI config #308

GitHub Actions CI config #308

twm commented Dec 22, 2020

adiroiban left a comment

adiroiban Dec 27, 2020

adiroiban Dec 27, 2020

twm Dec 27, 2020

adiroiban Dec 27, 2020

twm Dec 27, 2020

adiroiban commented Dec 27, 2020

twm commented Dec 27, 2020

	- run: tox -q -e flake8
	- run: tox -q -p all -e flake8, towncrier, twine, check-manifest


		- run: tox -e ${{ steps.pyfactor.outputs.value }}-twisted_${{ matrix.twisted-version }}

		- run: python -m pip install coveralls

GitHub Actions CI config #308

GitHub Actions CI config #308

Conversation

twm commented Dec 22, 2020

adiroiban left a comment

Choose a reason for hiding this comment

adiroiban Dec 27, 2020

Choose a reason for hiding this comment

adiroiban Dec 27, 2020

Choose a reason for hiding this comment

twm Dec 27, 2020

Choose a reason for hiding this comment

adiroiban Dec 27, 2020

Choose a reason for hiding this comment

twm Dec 27, 2020

Choose a reason for hiding this comment

adiroiban commented Dec 27, 2020

twm commented Dec 27, 2020