Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ignoring non-string headers #298

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Deprecate ignoring non-string headers #298

merged 4 commits into from
Oct 23, 2020

Conversation

twm
Copy link
Contributor

@twm twm commented Sep 30, 2020

Closes #294.

This is built on #297. I'll rebase it once that's in.

@twm twm force-pushed the 294-non-string-headers branch from f3c0be4 to 2b7c65e Compare October 10, 2020 01:30
@twm twm marked this pull request as ready for review October 10, 2020 01:30
@twm twm requested a review from a team October 10, 2020 01:30
ryban
ryban approved these changes Oct 23, 2020
View reviewed changes
Copy link

@ryban ryban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@twm
Copy link
Contributor Author

twm commented Oct 23, 2020

Thanks @ryban! I'll get out a release soon.

@twm twm merged commit 80e52e2 into master Oct 23, 2020
@twm twm deleted the 294-non-string-headers branch October 23, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryban ryban ryban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

treq will silently ignore invalid non-string header values
2 participants
@twm @ryban