Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct RequestSequence response tuple type docs #237

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Correct RequestSequence response tuple type docs #237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dd8c2f
Correct RequestSequence response tuple type docs
twm Mar 6, 2019
84f1c81
Merge branch 'master' into testing-response-headers-docs
twm Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/treq/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ class RequestSequence(object):

- ``code`` is an integer representing the HTTP status code to return.
- ``headers`` is a dictionary mapping :class:`bytes` to :class:`bytes` or
:class:`list` of :class:`bytes`.
:class:`str`. Note that the value is *not* a list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the format for header items with multiple values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They cannot be represented in this API. :-/ You could send the semantic equivalent with a comma... *mumble mumble cookies*...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch. Okay.

- ``body`` is a :class:`bytes`.

:ivar list sequence: A sequence of (request tuple, response tuple)
Expand Down