Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve suffix parsing in issue_pattern #654

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Aug 6, 2024

Description

Fixes #653

Use internal issue name parser instead of parsing (again) the file name.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.

@dorschw dorschw requested a review from a team as a code owner August 6, 2024 08:42
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@adiroiban adiroiban merged commit 543db79 into twisted:trunk Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue_template fails on .md-suffixed files
2 participants