-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore documentation to source manifest #672
Comments
It looks like this change was done as part of this PR #368 I am not sure what is requested here. Why do we need the documentation source for the Python sdist package ? The documentation source is designed to be used by the Read The Docs service. Is this about the I think that the idea was to use We might want to add some info in our README or docs to help distribute We already have the docmentation for the CLI duplicated in ReStructuredTest and Click Help format. In an ideal case, the CLI documentation is only defined in From |
@adiroiban wrote:
The request is for Source Distribution to include what is needed for building the package for local installation:
That was already happening, and this request is to restore the documentation source by updating the Source Manifest to include it. @adiroiban wrote:
Because the documentation source is part of the source for this project, and is needed to change and build that documentation. The Source Distribution allows access to this source without needing further network access; and having the documentation build and installed locally allows accessing it without requiring network.
I hope you can appreciate that programs should not be unnecessarily dependent on network access merely to read their documentation. Distributing the documentation source as part of the Source Distribution ensures that standard way of building the entire package from distributed source, as described in the Python Packaging Guide quoted above.
All the documentation that you consider part of this project, yes. Please ensure it is part of the Source Distribution, by restoring its source to the source manifest. |
Thanks Ben for the information. I appreciate all the hard work done by the Debian project. I have created #673 to fix this This is ready for review. I hope all is ok and we can merge it soon. |
Please restore the documentation source, to the source manifest (so that it is included in the Python sdist).
In commit 6463b5a a
recursive-exclude
was added to the 'Manifest.in' file, deliberately excluding the documentation source from the sdist.That commit has no explanation for the change; the commit message in its entirety is "fixes".
Please revert that change, and include the documentation in the sdist as before.
The text was updated successfully, but these errors were encountered: