Add python 3.13 support, drop 3.7 and 3.8 #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #790 +/- ##
==========================================
- Coverage 99.08% 99.03% -0.05%
==========================================
Files 48 48
Lines 4045 4045
Branches 545 545
==========================================
- Hits 4008 4006 -2
- Misses 23 24 +1
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. |
adiroiban
approved these changes
Oct 30, 2024
| @@ -193,27 +193,26 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: ["ubuntu-latest"] | |||
| python-version: ["3.7", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.9", "3.10", "3.11"] | |||
| twisted-version: ["21.2", "22.1", "23.8"] | |||
There was a problem hiding this comment.
Maybe this also should be updated...
and add a comment to describe what rule do we use to define the targeted twisted versions ...
Suggested change
| twisted-version: ["21.2", "22.1", "23.8"] | |
| # We have the oldest Twisted version that we support. | |
| # We also add the last 2 newer versions. | |
| twisted-version: ["21.2", "24.7", "24.10"] |
| twisted-version: "23.8" | ||
| tox-prefix: "test" | ||
| optional: false | ||
| # Test Python 3.12 but allow it to fail | ||
| - os: "ubuntu-latest" |
There was a problem hiding this comment.
I think that a comment describing this job can help with future updates of these values.
Suggested change
| - os: "ubuntu-latest" | |
| # Test latest supported Python | |
| # and latest Twisted release. | |
| - os: "ubuntu-latest" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this didn't require any code changes, no release is required, but this at least ensures 3.13 will keep working going forward.
I also dropped 3.7 and 3.8, as they are no longer received security updates.