-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop the interaction of hypothesis and disttrial from hanging the tests #571
Conversation
see also python/cpython#28525 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 44 44
Lines 3883 3887 +4
Branches 519 520 +1
=======================================
+ Hits 3846 3850 +4
Misses 23 23
Partials 14 14
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi.
I have close to zero experience with hypothesis.
But I guess the changes are fine and this can be merged.
Thanks!
Another reference - HypothesisWorks/hypothesis#3585 |
@exarkun does that reference tell us when we can remove this gross hack? :) |
This comment seems to suggest the fix will be in the next bugfix release of Python 3.11 and the next major release. There is also an upstream bug report which is closed now (and seems like a duplicate of the cpython bug report linked here, above). |
Thanks for those references! |
something that disttrial is doing is making it so that a threading.local() reference being kept by a recursive hypothesis strategy (but only if it is actually recursive!) retained at module scope getting torn down during interpreter finalization prevents both workertrial and the parent disttrial processes from exiting, hanging forever