-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Hatchling plugin #97
Conversation
f0b9374
to
d68f189
Compare
As the Hatch plugin is opt-in via some pyproject.toml noise I don't want to require a redundant [tool.incremental] section.
The PyPA packaging user guide refers to it as "Hatchling", so match that terminology.
This is documented behavior so it should have tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a very quick review.
I don't care too much about incremental or hatchling ... so this is a superficial review.
At the same time, other tha you Tom, I don't know if there are other maintainers for the incremental
project.
So as long as you are happy with the PR. It can be merged.
I see that this also updates the build system with locked / fully pinned dependencies.
I know that CI were failing in the past due to various deps missmatch.
At the same time, executing the tests using just the deps resolved by pip
at test runtime should produce a testing environment that is closed to what newer users might experience.
I am approving this, so that this PR can be merged.
I have also added back Twisted contributors, if someone else who cares more about incremetal
will want to review it.
If in a few theres, there are no other reviews, I think that this can be merged.
I guess that once a new version is released, incremental
can use hatching for its build system.
Thanks
Thank you for the review @adiroiban! I'll try to release Incremental ASAP so you can use it in the next Twisted release.
Agreed, I have somewhat mixed feelings about this. However the dep tree is large enough with both Twisted and Hatch in the mix that I'd prefer to lock. |
Fixes #93.