Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Hatchling plugin #97

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Add a Hatchling plugin #97

merged 10 commits into from
Jul 23, 2024

Conversation

twm
Copy link
Contributor

@twm twm commented Jul 20, 2024

Fixes #93.

@twm twm changed the base branch from 81-dotless to trunk July 20, 2024 22:06
@twm twm changed the title Add a Hatch plugin Add a Hatchling plugin Jul 20, 2024
@twm twm force-pushed the 93-hatch branch 3 times, most recently from f0b9374 to d68f189 Compare July 21, 2024 00:42
twm added 7 commits July 20, 2024 17:43
As the Hatch plugin is opt-in via some pyproject.toml noise I don't want
to require a redundant [tool.incremental] section.
The PyPA packaging user guide refers to it as "Hatchling", so match that
terminology.
This is documented behavior so it should have tests.
@twm twm requested a review from a team July 21, 2024 00:46
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a very quick review.
I don't care too much about incremental or hatchling ... so this is a superficial review.

At the same time, other tha you Tom, I don't know if there are other maintainers for the incremental project.

So as long as you are happy with the PR. It can be merged.


I see that this also updates the build system with locked / fully pinned dependencies.

I know that CI were failing in the past due to various deps missmatch.

At the same time, executing the tests using just the deps resolved by pip at test runtime should produce a testing environment that is closed to what newer users might experience.


I am approving this, so that this PR can be merged.

I have also added back Twisted contributors, if someone else who cares more about incremetal will want to review it.

If in a few theres, there are no other reviews, I think that this can be merged.


I guess that once a new version is released, incremental can use hatching for its build system.

Thanks

src/incremental/newsfragments/93.feature Outdated Show resolved Hide resolved
@adiroiban adiroiban requested a review from a team July 22, 2024 10:04
@twm
Copy link
Contributor Author

twm commented Jul 23, 2024

Thank you for the review @adiroiban! I'll try to release Incremental ASAP so you can use it in the next Twisted release.

I see that this also updates the build system with locked / fully pinned dependencies.

I know that CI were failing in the past due to various deps missmatch.

At the same time, executing the tests using just the deps resolved by pip at test runtime should produce a testing environment that is closed to what newer users might experience.

Agreed, I have somewhat mixed feelings about this. However the dep tree is large enough with both Twisted and Hatch in the mix that I'd prefer to lock.

@twm twm merged commit 6d1e5cc into trunk Jul 23, 2024
7 checks passed
@twm twm deleted the 93-hatch branch July 23, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hatch plugin
2 participants