Fix bib resource finding, subprocess call, and upcoming deprecation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `make_author_year_tokens_from_bib()` so that bib items that don't have authors (e.g. books with editor lists) are still handled correctly. Also moved some re.compile() calls outside the loop for efficiency.
Fix crash when no authors present
|
Wow. Thanks for putting this together. I haven't tested yet, but the next time I use this (for a paper revision due in 4 weeks) I'll be using this version. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as discussed in #12, I've forked the repo and applied my changes. It turned out I had to do one other fix to debug my current installation, so it's now a slightly bigger PR. In detail:
I'm merging it into the
developbranch as requested in the guidelines even though it's a bit behind on commits, maybe that should be changed to the main branch. I also haven't run any tests yet since I made the commits from a non-TeX machine and thetoxsetup also seemed pretty outdated. @twilsonco if you could run the tests that'd be amazing, then we would also have a second check, but if not, I can do them sometime in the future.Cheers