Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(socket): throw an error when the socket fails to connect #232

Conversation

kamalbennani
Copy link
Contributor

@kamalbennani kamalbennani commented Dec 28, 2023

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

This PR aims to fix the issue described here: #231

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

@kamalbennani kamalbennani force-pushed the fix/throw-error-when-socket-fails-to-be-created branch from c4426f1 to ec78d5d Compare December 28, 2023 10:14
@kamalbennani
Copy link
Contributor Author

Hi @charliesantos
Would you mind taking a look at this PR whenever you have time.
Really appreciate it.

@charliesantos
Copy link
Collaborator

Good find @kamalbennani ! Thanks for submitting. I created an internal ticket to have this reviewed and tested further.

@kamalbennani
Copy link
Contributor Author

Thanks @charliesantos

@kamalbennani
Copy link
Contributor Author

Hi @charliesantos
Any update on this?
Can we get it release this week if it passes the validation?
Thanks buddy.

@charliesantos
Copy link
Collaborator

Hi @kamalbennani. It's in our queue. ETA is 1-2 weeks.

@charliesantos
Copy link
Collaborator

@kamalbennani I submitted a new PR to capture your changes. I also made a few modifications so that handlers are getting cleaned up properly. See it here #236
As always, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants