Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client vs voice references #223

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix client vs voice references #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions COMMON_ISSUES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Having an issue with twilio.js? Review this list of common issues to determine
or not your issue is known or a workaround is available. Please also take a look at the
[CHANGELOG.md](CHANGELOG.md) to see if your issue is known for a particular
release. If your issue hasn't been reported, consider submitting
[a new issue](https://github.com/twilio/twilio-client.js/issues/new).
[a new issue](https://github.com/twilio/twilio-voice.js/issues/new).

Working around the browsers' autoplay policy
--------------------------------------------
Expand Down Expand Up @@ -53,12 +53,12 @@ Aggressive Browser Extensions and Plugins
-----------------------------------------

Some browser extensions and plugins will disable WebRTC APIs, causing
twilio-client.js to fail. Examples of such plugins include
twilio-voice.js to fail. Examples of such plugins include

* uBlockOrigin-Extra
* WebRTC Leak Prevent
* Easy WebRTC Block

These are unsupported and likely to break twilio-client.js. If you are having
trouble with twilio-client.js, ensure these are not running.
These are unsupported and likely to break twilio-voice.js. If you are having
trouble with twilio-voice.js, ensure these are not running.

6 changes: 3 additions & 3 deletions tests/framework/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Framework Tests

Framework Tests ensure twilio-client.js works with popular JavaScript frameworks,
Framework Tests ensure twilio-voice.js works with popular JavaScript frameworks,
such as

* No Framework (Script tag)
* React

With each of these frameworks, there are a variety of ways to use them,
complicating the task of ensuring twilio-client.js actually works with them. We
complicating the task of ensuring twilio-voice.js actually works with them. We
focus on the most common use cases—for example, React apps created with
`create-react-app` or Angular apps created from the Quickstart seed.

Expand All @@ -22,7 +22,7 @@ The Test Application

## Consuming Framework Tests

The twilio-client.js build process will
The twilio-voice.js build process will

1. Reinstall each Framework Test from scratch,
2. Run any project-specific tests, and finally
Expand Down
2 changes: 1 addition & 1 deletion tests/framework/no-framework/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
twilio-client-no-framework
=========================

This is the Test Application for ensuring that twilio-client.js works without any
This is the Test Application for ensuring that twilio-voice.js works without any
Test Framework.

Usage
Expand Down
2 changes: 1 addition & 1 deletion tests/framework/react/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
twiliojs-react
==================

This is the Test Application for ensuring that twilio-client.js works with React.
This is the Test Application for ensuring that twilio-voice.js works with React.
The project was created with `create-react-app`, and then further reduced to the
bare essentials.

Expand Down