bug: fixed query param not going for delete

twilio · Dec 14, 2023 · 30fd6b3 · 30fd6b3
1 parent 53d29ad
commit 30fd6b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/lib/twilio-ruby/http/http_client.rb b/lib/twilio-ruby/http/http_client.rb
@@ -39,6 +39,7 @@ def _request(request) # rubocop:disable Metrics/MethodLength
           f.proxy = "#{@proxy_prot}://#{@proxy_auth}#{@proxy_path}" if @proxy_prot && @proxy_path
           f.options.open_timeout = request.timeout || @timeout
           f.options.timeout = request.timeout || @timeout
+          f.params = request.params.nil? ? {} : request.params
 
           @configure_connection_blocks.each { |block| block.call(f) }
           f.adapter @adapter
@@ -65,7 +66,7 @@ def _request(request) # rubocop:disable Metrics/MethodLength
       def send(request)
         @connection.send(request.method.downcase.to_sym,
                          request.url,
-                         request.method == 'GET' ? request.params : request.data)
+                         request.data)
       rescue Faraday::Error => e
         raise Twilio::REST::TwilioError, e
       end

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -19,6 +19,7 @@
 require 'twilio-ruby'
 require 'rspec/matchers'
 require 'equivalent-xml'
+require 'rspec/core'
 
 RSpec.configure do |config|
   config.expect_with :rspec do |c|