Declare support for Python 3.8 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.8 is there, so I believe that it would be nice to declare support and add tests for it on CI. Python 3.8.0 release announcement: https://discuss.python.org/t/python-3-8-0-is-now-available/2478
jayvdb
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Note deprecation warning occurring in build
/opt/python/3.8.0/lib/python3.8/unittest/case.py:1215: DeprecationWarning: assertDictContainsSubset is deprecated
warnings.warn('assertDictContainsSubset is deprecated',
Not a blocker for declaring support for py38 as the problem is only in the test logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is there, so I believe that it would be nice to declare support and add tests for it on CI.
Python 3.8.0 release announcement:
https://discuss.python.org/t/python-3-8-0-is-now-available/2478
Contributing to Twilio