Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: RequestClient updated to become more customizable #778

Merged
merged 3 commits into from
Aug 11, 2022
Merged

feat: RequestClient updated to become more customizable #778

merged 3 commits into from
Aug 11, 2022

Conversation

mattcole19
Copy link
Contributor

Fixes

This PR allows RequestClient to be more customizable by taking in and setting arguments for https.Agent. Aligns with #775.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

childish-sambino
childish-sambino reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title has a leading space that's causing the linter to error.

lib/base/RequestClient.d.ts Outdated Show resolved Hide resolved
@mattcole19 mattcole19 changed the title feat: RequestClient updated to become more customizable feat: RequestClient updated to become more customizable Aug 9, 2022
childish-sambino
childish-sambino approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mattcole19 mattcole19 merged commit c7d5f33 into main Aug 11, 2022
@mattcole19 mattcole19 deleted the DI-2179 branch August 11, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattcole19 @childish-sambino