Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ttl optional in ClientCapabilityOptions #707

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

ghmeier
Copy link
Contributor

@ghmeier ghmeier commented Nov 4, 2021

Fixes

Resolves #699

Makes ttl optional in ClientCapabilityOptions since the constructor doesn't require a value and provides a default.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Garret Meier and others added 2 commits November 4, 2021 10:32
Resolve issue twilio#699 by making ttl optional in ClientCapabilityOptions
since the constructor doesn't require a value and provides a default.
@shwetha-manvinkurke shwetha-manvinkurke merged commit 11f728a into twilio:main Nov 10, 2021
@ghmeier ghmeier deleted the fix-client-capabilities-type branch November 18, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types: ClientCapabilityOptions makes ttl required but it's optional.
3 participants