fix: url encoding for validateExpressRequest #642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Reverts #621
621 breaks
validateExpressRequest
.Replacing of these URL-encoded characters is not correct since ":", and "@" are reserved characters that should be URL-encoded and are probably being URL-encoded by most customers (correctly using encodeURIComponent instead of something incorrect like encodeURI)
https://nodejs.org/api/querystring.html#querystring_querystring_stringify_obj_sep_eq_options
Checklist