added request validation for urls with and without ports #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(isValid).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should validate urls with credentials by adding port', () => { |
There was a problem hiding this comment.
This appears to be the same as the should validate urls with credentials test.
There was a problem hiding this comment.
This one ensures standard ports are added to the URL for validation. Note the expected signatures of these two tests are different, but they both pass.
thinkingserious
approved these changes
Oct 21, 2019
| */ | ||
| function buildUrlWithStandardPort(parsedUrl) { | ||
| let url = ''; | ||
| const port = parsedUrl.protocol === 'https:' ? ':443' : ':80'; |
There was a problem hiding this comment.
Should add a case for the gopher protocol (:
https://nodejs.org/api/url.html#url_url_port
This was referenced Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for DI-320
Fixes #411